Discussion:Field of Vision
(→Other points for consideration) 
(add subsections, to help liking) 

Line 505:  Line 505:  
= Other points for consideration =  = Other points for consideration =  
+  
+  == Cases and examples ==  
* Should @'s and M's have an infinite field of view?  * Should @'s and M's have an infinite field of view?  
Line 541:  Line 543:  
@ can't see G (but can see wall G is in).  @ can't see G (but can see wall G is in).  
−  +  == Extra visibility properties ==  
7. '''Retreating is safe'''. If you keep retreating into a corridor, once you are hidden from an immovable monster's sight, you stay hidden; this applies for arbitrarily twisted corridors of width 1 (probably enough to consider digital lines). With symmetry, this implies that retreating doesn't improve your sight, either.  7. '''Retreating is safe'''. If you keep retreating into a corridor, once you are hidden from an immovable monster's sight, you stay hidden; this applies for arbitrarily twisted corridors of width 1 (probably enough to consider digital lines). With symmetry, this implies that retreating doesn't improve your sight, either. 
Revision as of 13:32, 20 October 2011
Contents

Tenets
These were originally posted by PaulBlay, and were later expanded. All of these are not necessarily desirable, and some of them may be mutually exclusive.
Visibility properties:
 Symmetry. Everything you see can see you, and vice versa.
 Expanding pillar shadows. Standing directly next to a pillar produces an expanding shadow.
 Efficiency. Reasonably fast code can be produced to implement the FOV, etc.
 No blind corners. Moving diagonally around a corner does not place you in melee range of a previous nonvisible tile.
 Expansive wall display. You can see all of a room's walls while standing anywhere inside of it, and all walls of a long, straight corridor. This can either be a natural property of the algorithm used (in which case the walls are visible) or handled as a special case (considered displayed but not generally visible or targetable).
 No hidden ghosts. Passwall monsters inside of visible walls are always visible.
Targeting properties:
 Visible = Targetable. You can target any visible tile.
 Nonexploitable. No trick shots required or possible to hit monsters that you can't target directly.
 No lost targeting. Casting stonetomud on a walled, targetable ghost does not cause you to lose targeting on that tile.
Expansive visible walls with no hidden ghosts, visible = targetable and symmetry may allow passwall monsters to target players from a lot further away than now (see DFOV).
Terminology
Field of View
The field of view refers to the set of squares that are considered visible. For the current discussion, this should not include squares that are known to the player due to ESP, detection, etc. FOV algorithms under discussion all operate by determining if a lineofsight (LOS) exists between the player and each other game square; actual implementations will probably optimize this calculation. One can imagine FOV algorithms which do not use LOS.
Line of Sight
A path between the player and a visible square. Different LOS algorithms will use different strategies for specifying what part(s) of the source and destination squares are eligible to have lines between them (e.g. the center of the square), what part(s) of wall squares will block LOS, and how many lines must be drawn to have LOS.
Projectile Path
Projectile path refers to the path that a projectile (e.g. an arrow) will travel on its way from a player to a visible square. This is important if intervening monsters can possibly block a projectile from reaching its destination. Some systems may not allow this (in which case LOS == projectile path is trivial) and some will check a path of squares in a given order which are either guaranteed to absorb the shot (as Angband does now), or have a percentage chance to do so. If LOS == targetability then it's important that squares which didn't block LOS not block a projectile. However, some systems may want to those squares absorb projectiles when occupied. Thus, in addition to LOS, it's important to be clear how projectile paths should work.
NOTE: Many of these systems don't make clear how they expect to handle projectile path; it would be great to add this, since implementing FOV/LOS changes in Angband without modifying project_path() won't result in useful changes to gameplay.
Symmetrization
Logicaland and Logicalor Symmetrization
Any visibility algorithm that is not symmetric, admits two obvious ways of transforming to an algorithm that is symmetric. Assume that for any two squares x,y in a given collection, that a visibility function V(x,y) is defined, and returns true or false.
 The intuitive way of defining that the visibility function is symmetric: V(x,y)=V(y,x) .
 The least confusing formal way of defining that a visibility algorithm is symmetric, is to say that a visibility algorithm is symmetric if and only if the visibility function defined by the visibility algorithm is symmetric. (Informally, just conflate the visibility algorithm with the visibility function it defines.)
 Logicaland symmetrization: V_{AND}(x,y) := V(x,y) AND V(y,x), where AND denotates the traditional logicaland logical connective. Corresponding functional notation: V > V_{AND} .
 Logicalor symmetrization: V_{OR}(x,y) := V(x,y) OR V(y,x), where OR denotates the traditional logicalor logical connective. Corresponding functional notation: V > V_{OR}
Both V_{AND} and V_{OR} are symmetric visibility functions by construction.
While these definitions are meaningful for alreadysymmetric visibility functions, they both have no effect. Like any other possible way of construction symmetric visibility functions from asymmetric visibility functions, both V > V_{AND} and V > V_{OR} are idempotent functions of functions i.e. functors. [ V(x,y)=V_{AND}(x,y)=V_{OR}(x,y) for all symmetric visibility functions V, and squares x,y for which said visibility function is defined. ]
It is plausible that when a visibility algorithm V has expansive wall display, the logicalor symmetrized V_{OR} never has expanding pillar shadows.
Visibility Ether
An alternate way of implementing the symmetry property for visibility and targetability, is to define a preferred viewpoint for visibility/targetability (usually @)  then use this viewpoint for calculating both player visibility/targetability, and monster visibility/targetability.Bessarion: this is "visibility ether" in honor of the final effort to reconcile Maxwell's equations with the Galilean transform traditionally used in Newtonian physics, the ether.
This gets the symmetry property while retaining an asymmetric visibility function V. Even when V(x,y)≠V(y,x), symmetry is attained regardless: for @ with position x and monster with position y, both visibility checks are done with V(x,y). Of course, transposing the player and the monster will end up using V(y,x). For an asymmetric visibility function V, this does mean transposing a player and monster that can see each other, could end up rendering both player and monster mutually unable to see each other. This is still symmetric visibility.
Vanilla Angband has inconsistently used this for some time  not to determine the monster's ability to target the player, but as part of determining whether the monster has a turn at all. NPP reportedly uses this symmetrization technique in recent versions for both visibility and targetability.
Algorithms
Digital FOV
Description
Digital field of view was first mentioned by Atanvarno. The player and monsters are treated as diamonds, with the four points centered on the containing tile's edge. Drawing an unobstructed line from any part of one diamond to another diamond implies visibility. Walls may be treated as diamonds as well, both for visibility and obstruction.
Properties and advantages
Symmetry, efficiency, no blind corners, naturally expansive visible walls, no hidden ghosts. A demo implementation already exists, and has no known visibility artifacts.
Possible disadvantages
 DFOV lacks expanding pillar shadows. Small groups of adjacent wall will still produce a conical shadow effect.
 From any location inside a corridor, the player can see 1 tile around the corner. By standing on the corner, the player can see all the way down both corridors, including walls. Combined with a targeting system that implements Visible = targetable, passwall monsters may become significantly more challenging because they could use breath and spells from the safety of a wall tile at great distances, unless the player is given the ability to return fire with spells and/or ranged attacks. Being able to target the passwaller is not enough; currently player ranged attacks fail when entering a ghostoccupied wall tile.
 This method can produce regions of discontinuous shadows at oblique angles and large distances.
Consequences
Fig 1. Digital FOV ex. %'s are walls out of sight.
%%%%#%% % . %% ###%% % ...# ##....# @.....#%%%% ##........#% % ...###... % ..# %%%% %%%%##
Fig 2. Narrow and discontinuous pillar shadows
...@... @...... @............ @.................. ...#... .#..... ..#.......... ...#............... ... ... .. .... .... ........ ...... ............ ... ... ... ... ...... ...... ......... ......... ... ... .... .. ........ .... ............ ...... ... ... ..... . .......... .. ............... ... ... ... ...... ............ ..................
Fig 3. A room 25% full of pillars.
.. ... .. #.# #.# #.# . .# #.# #. . ... ... ... .. .. ... .. .. #.# #.# #.# #. .# #.# #. .# ... ... ... .. ....... .. #.# #.# #.# #. .#.#. .# ......... .. ... .. .#.#.#.#.#.#.#.#.#.#. .#.#.#.#.#.#.#.#. ..................... ........@........ #@# .#.#.#.#.#.#.#.#. ..................... .. ... .. .#.#.#.#.#.#.#.#.#.#. #. .#.#. .# ......... .. ....... .. #.# #.# #.# #. .# #.# #. .# ... ... ... .. .. ... .. .. #.# #.# #.# . .# #.# #. . ... ... ... .. ... .. #.# #.# #.#
Diamond walls, point visibility
Description
Walls are considered diamondshaped obstructions, with the 4 points of the diamond centered on the edges of the containing tile. Visibility between two tiles is implied by drawing an unobstructed line between the centers of the two tiles. The four points of the obstructing diamond do not obstruct visibility unless that point is adjacent to another wall tile (this allows extra visibility around corners, but prevents sight through walls).
Properties and advantages
Symmetry, expanding pillar shadows, efficiency, no blind corners, no hidden ghosts. Ghosts are not visible in corridor walls from great distances, and thus pose no problem for a targeting system that uses visible = targetable.
Possible disadvantages
This method lacks naturally expansive visible walls which means part of a room's walls will not be visible to a player standing inside the room, if he is close to a wall or a corner. This is more pronounced the closer to a wall, and the larger the room. This could be corrected by automatically adding map memory for the walls of lit rooms, so while only some of the walls would be visible (and marked with a special color) all the walls of the room would appear to the player.
A second pointtodiamond "tile visibility" check could be made to add extra visibility for wall tiles, but this would break no hidden ghosts and possibly no lost targeting.
This method can produce regions of discontinuous visibility at oblique angles (see below).
Consequences
Fig 4. Conical pillar shadows
...@... @...... @............ @.................. ...#... .#..... ..# ........ ...# ............. ... ... .. ... ... ..... ..... ....... .. .. .. . ..... . ....... . .. .. ... ...... ......... . . ... ....... ........... . . .... ......... .............
Not all walls (or doors/monsters in those locations) are visible from all locations inside of a room.
Fig 5. Nonvisible room walls.
####????? #####???? ?#####??? ??#####?? #@....... #.@...... #..@..... #...@.... #........ #........ #........ #........ #........ #........ #........ #........ ?........ #........ #........ #........ ?........ #........ #........ #........ ?........ ?........ #........ #........ ?........ ?........ #........ #........
Fig 6. Discontinuous point visibility
@#????? ... ###.# . ?.? ?.?
Halfwidth walls, center to center
Suggested by Eddie(PowerDiver).
This is a symmetrical system.
Consequences:
Fig 7. Corridor walls / monsters seen forever.
################D @
@ can see D, D can see @
Fig 8. Indeterminate (resolve to not visible).
##D ## @
Fig 9. Diagonal move safety.
#m # @#
Vital that @ can see m in this case.
Fig 10. Pillar blocking sight.
...................... .@# M ......................
@ cannot see M (by zerowidth blockage subrule  see fig 5)
Fig 11. Discontinuous gaps in viewable area (by zerowidth blockage)
....... .@..... ...#... ..... . .......
Monsters occupy half the width/height of grid
Monsters, characters, items are in the center of their grid's square taking up onequarter of it's area (half the width/height). If lines from any point in the @'s subsquare can go to any point in the M's subsquare without crossing a wall then each is visible by the other. Walls take up the full grid square.
This is a symmetrical system.
Consequences.
Fig 12. @ cannot see D.
#####D###### @
Fig 13. It is indeterminate whether @ can see D or not (zerowidth cross).
####D####### @
Fig 14. @ can see D and D can see @
###D######## @
Center to Center, subdivided grid
Any tile that can have a line drawn from the center of the @ to the center of the tile is without crossing an obstructed point is visible. Each wall takes up the middle 2x2 of the 4x4 subdivided grid.
For visibility purposes a monster on a walltile is not treated differently from a monster on a floor tile.
Consequences.
Fig 15. From the entrance of a room.
#######.####### #######@####### ????.......???? ?.............?
Fig 16. @ cannot see M.
................? .........???????? .@.###?????M????? .........???????? ................?
Fig 17. Expanding shadow triangle from pillar.
@........... ...#?....... .....????... .......????? .........???
Fig 18. @ cannot see D.
####D @...
Fig 19. @ can just see D (by allowing zero width cross).
###D# @...
Traditional (Angband)
Trick shots are possible (e.g. you can shoot at indirectly targeted grids that you cannot see or target directly).
Consequences.
Fig 20. A cannot see X but can hit it by shooting at B.
###X.B A.....
Zaiband FOV and targetting
Fig 21. One pillar cases.
.....? ...??? @#???? ...??? .....?
...?? ...?? ..??? ..??. .#... @....
In a plain rectangular room: identical to V, except you can target anything you can see that isn't in a wall. The projection path enabling visibility will automatically swerve as needed, thanks to Tyrecius' Permissive Field of View techniques.
Fig 22. Entering a room
Tintersections and entering rooms are a bit more dangerous in Zaiband:
??. ??. ?.. #.. @.. #.. ?.. ??. ??.
has a reasonable ambush by D:
### #D. #.. #.. #.. @.. #.. #.. #.. #..
Problem being that that with all trick shots being handled automatically, all visible/targetable floor squares are fair game for ground zero of a ball spell; @ can be targeted by D but not conversely.
Fig 23. Symmetrized viewability/projection algorithm (considered as an extra option for Zaiband)
?## ?D. ?.. ?.. #.. @.. #.. #.. #.. #..
Fig 24. No hockypucks.
Zaiband abolishes the hockey puck by allowing offdiagonal projections to start diagonally:
??o ?x# #x# @.#
In V, this fails because the first step is into the wall to the north.
I proceeded with Zaiband by first simplifying V's base projection algorithm; this stopped hockey pucks as a side effect. Cf. flow.c for end result. [V starts directly emulating fractional steps at the second step. Zaiband does so starting at the first step.] If there are fixable problems with the initial projection path (offsets directly along an axis or primary diagonal do not admit fixing):Zaiband defines visibility as "illuminated, and projectable with a wand/rod of light". I was pleasantly surprised that this automatic fixup gets all advocated properties except symmetry; the player need never calculate trick shots. Imposing either logicalor symmetry or logicaland symmetry would be a rote change.  Bessarion
 Check for standard oneoff trick shots that anyone can handcalculate: abs(Δx)==1, abs(Δy)==1, or abs(abs(Δx)abs(Δy))==1. If they are applicable, use them.
 If no standard oneoff trick shot applies, fall back to Permissive Field of View.
 We use rational tangent values as proxies for the actual angles.
 The simplified base projection algorithm admits trivial calculation of the upper and lower rational tangent values for both hitting the target square, and hitting the obstruction. Take the set difference and see if the resulting interval is nonempty.
 empty: target square is nonprojectable.
 nonempty: use tangent angle summation and halfangle formulæ to determine a suitable positional target. Retry the base algorithm. If this path is obstructed, repeat the Permissive Field of View correction.
Pete Mack's Desiderata
Here's a summary of what I understand from this discussion, along with some of my preferences.
I will assume that walls are convex hulls around diamondshaped wall gridsit makes more sense than anything else.
Definitions: LOS(p1, p2) line from point p1 to point p2 misses (or is tangent to) any intervening wall diamonds.
T(a, b) grid b is targetable from grid a. (Targeting Line of Sight TLOS)
V(a, b) grid b is visible from grid a. (Visual Line of Sight VLOS)
C(a) center point of grid a
These are my desiderata:
1. Target symmetry
1a. assuming a is not a wall and b is not a wall.
 T(a, b) == T(b, a)
##o# If @ can target o then o can target @. @..# ####
1b. For ghosts in the wall, ghost is treated as in an empty square for T(G,@), but is treated as a wall block for T(@, G)
##D# D can target @ but @ can't target D. @... ####
2. LOS symmetry
 V(a, b) == V(b, a)
##o# If @ can see o then o can see @. @..# ####
3. Dominance of V over T. This guarantees VLOS for reverse T(G,@)
 T(a, b) ⇒ V(a, b)
##### All targetable o can be seen .@ooo (but may not be able to target every o that can be seen). ###oo
4. Unpermissive TLOS (I lean towards 4a)
4a By center:
 LOS(C(a), C(b)) ⇔ T(a, b) [ ⇔ T(b, a) ]
A line of sight from center of grid a (@) to center of grid b (.) implies a is targetable by b and b is targetable by a.
4b Existential:
 ∀p1 ∈ a ∃p2 ∈ b LOS(p1, p2) ⇔ T(a, b)
A line of sight from any point in grid a (@) to any point in grid b (.) implies a can target b and b can target a.
5. Permissive VLOS. (I lean towards 5a)
5a. By center
 LOS(C(a), p2 ∈ b)  LOS(C(b), p1 ∈ a) ⇔ V(a, b)
5b. Existential:
 ∀p1 ∈ a , p2 ∈ b LOS(p1, p2) ⇔ V(a, b)
Am I missing anything in this? In this case, a picture may be worth a thousand words, but a little math is worth a thousand pictures. (You may conclude what you will by transitivity :D )
Additional desiderata:
6. Shadows shall not be disconnected. If a single grid wall casts a shadow at a some point, there must exist a (diagonally) connected path of shadow from the wall to the point. (In ordinary parlance: it always becomes easier to hide behind something as you get closer to it.)
6b. Let a, b be two grids which are both in shadow by a column at grid w of grid @. Then there must exist a continuous path from @ to W which is in shadow of both a and b. (This requires a lot more definitions to pose it in set notation, but it's still pretty straightforward.)
I think that 6 & 6b pretty much eliminate all the proposed models but the diamond algorithm applied to diamond (or cylindrical) shaped wall grids. (Model 5a in my earlier post.) I will try to prove it...
BTW: 6 does not imply that ASC's will work, but only if the monsters are smart:
########## #W#D#P# # ##U#R#@# # ##########
Depending on permissiveness, T(D,@), or even T(W,@), but not T(R,@). Cutting down on possibilities, 4a is a model for T(D,@), but not for T(W,@).
4b is a model for both T(D,@) and T(W,@) (and any (10) similarly situated monsters, up to d(M,@) <= 20 spaces away.)
Intentionally unsymmetrical
Monsters caught in open hallway have no where to hide. Intelligent @'s can peek round corners without being spotted.
Fig 25. @ can see M, but M can't see @.
#.# #####@# ..M...# #######
Other points for consideration
Cases and examples
 Should @'s and M's have an infinite field of view?
Fig 26. Should @ see M ? How long should maximum sight range be?
################################################################################################# .@.............................................................................................M. #################################################################################################
Special cases for walls (etc.)
Fig 27. @ can see the wall, and monsters in the wall, for as far as it goes.
################################################################################################ .@..............................................................................................
Fig 28. @ can see #, % are walls he can't see, ? is indeterminate
####?%%%%%% .@.........
The question is whether walls (but not monsters in walls) should be filled in when they are not visible, but are adjacent to room / corridor tiles that are visible and lit.
Fig 29. Special case wall visibility
#####G##### .@.........
@ can't see G (but can see wall G is in).
Extra visibility properties
7. Retreating is safe. If you keep retreating into a corridor, once you are hidden from an immovable monster's sight, you stay hidden; this applies for arbitrarily twisted corridors of width 1 (probably enough to consider digital lines). With symmetry, this implies that retreating doesn't improve your sight, either.
The Kuo Corridor from Precise Permissive Field of View is an extreme example in that even an algorithm that checks visibility between all corners and middle edge points of two tiles does not make the retreat safe. The property 7. is only satisfied by algorithms that analyze visibility between continuous sections of each of the two tiles, spanning the width of the corridor, not a small set of points in one of the tiles. Such algorithms are beam casting (e.g, parallel beams starting from diagonals of a tile), Digital FOV (visibility from a cross dividing a tile into 4 squares) and Precise Permissive FOV (visibility from an 'X' dividing a tile into 4 triangles). See https://github.com/Mikolaj/LambdaHack/wiki/Fovandlos for some more context. This property is related to the "shadows without holes" property, but here the holes may actually be between the shadow and a corridor wall, not inside the shadow. In other words, the property states that shadow borders intersect with any corridor at most once on each side of the player. Shadow aligns well with the corridor that casts it.